Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update spring-boot's version to 2.3.4.RELEASE #15671

Merged
merged 5 commits into from
Oct 22, 2020
Merged

Update spring-boot's version to 2.3.4.RELEASE #15671

merged 5 commits into from
Oct 22, 2020

Conversation

chenrujun
Copy link

@chenrujun chenrujun commented Sep 25, 2020 •
edited
Loading

gapra-msft
gapra-msft approved these changes Sep 28, 2020
View reviewed changes
Copy link
Member

@gapra-msft gapra-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Storage changes look good to me

@kushagraThapar
Copy link
Member

@chenrujun I investigated this issue today, and seems like Azure Cosmos SDK has an issue with netty library version 4.1.52.Final

This issue is easily reproducible with ChangeFeedProcessorTest on this PR.
These are the error logs I am seeing locally.

2020-09-29 17:36:58,661       [main] INFO  com.azure.cosmos.TestNGLogListener - beforeInvocation: TestSuiteBase#beforeSuite
2020-09-29 17:36:58,669       [TestNG-method=beforeSuite-1] INFO  TestSuiteBase - beforeSuite Started
2020-09-29 17:36:58,747       [TestNG-method=beforeSuite-1] INFO  com.azure.cosmos.implementation.RxDocumentClientImpl - Initializing DocumentClient with serviceEndpoint [https://paged-flux-test-account.documents.azure.com:443/], connectionPolicy [ConnectionPolicy{requestTimeout=PT5S, connectionMode=GATEWAY, maxConnectionPoolSize=1000, idleHttpConnectionTimeout=PT1M, idleTcpConnectionTimeout=null, userAgentSuffix='', throttlingRetryOptions=RetryOptions{maxRetryAttemptsOnThrottledRequests=9, maxRetryWaitTime=PT33H20M}, endpointDiscoveryEnabled=true, preferredRegions=null, multipleWriteRegionsEnabled=true, proxyType=null, inetSocketProxyAddress=null, readRequestsFallbackEnabled=true, connectTimeout=null, idleEndpointTimeout=null, maxConnectionsPerEndpoint=0, maxRequestsPerConnection=0}], consistencyLevel [Session], directModeProtocol [Tcp]
2020-09-29 17:36:58,959       [parallel-1] INFO  com.azure.cosmos.implementation.RxDocumentClientImpl - Getting database account endpoint from https://paged-flux-test-account.documents.azure.com:443/
2020-09-29 17:36:59,156       [reactor-http-nio-1] WARN  io.netty.channel.DefaultChannelPipeline - An exceptionCaught() event was fired, and it reached at the tail of the pipeline. It usually means the last handler in the pipeline did not handle the exception.
io.netty.channel.ChannelPipelineException: reactor.netty.resources.PooledConnectionProvider$PooledConnectionAllocator$PooledConnectionInitializer.handlerAdded() has thrown an exception; removed.
	at io.netty.channel.DefaultChannelPipeline.callHandlerAdded0(DefaultChannelPipeline.java:624) [netty-transport-4.1.52.Final.jar:?]
	at io.netty.channel.DefaultChannelPipeline.access$100(DefaultChannelPipeline.java:46) [netty-transport-4.1.52.Final.jar:?]
	at io.netty.channel.DefaultChannelPipeline$PendingHandlerAddedTask.execute(DefaultChannelPipeline.java:1463) [netty-transport-4.1.52.Final.jar:?]
	at io.netty.channel.DefaultChannelPipeline.callHandlerAddedForAllHandlers(DefaultChannelPipeline.java:1115) [netty-transport-4.1.52.Final.jar:?]
	at io.netty.channel.DefaultChannelPipeline.invokeHandlerAddedIfNeeded(DefaultChannelPipeline.java:650) [netty-transport-4.1.52.Final.jar:?]
	at io.netty.channel.AbstractChannel$AbstractUnsafe.register0(AbstractChannel.java:502) [netty-transport-4.1.52.Final.jar:?]
	at io.netty.channel.AbstractChannel$AbstractUnsafe.access$200(AbstractChannel.java:417) [netty-transport-4.1.52.Final.jar:?]
	at io.netty.channel.AbstractChannel$AbstractUnsafe$1.run(AbstractChannel.java:474) [netty-transport-4.1.52.Final.jar:?]
	at io.netty.util.concurrent.AbstractEventExecutor.safeExecute(AbstractEventExecutor.java:164) [netty-common-4.1.52.Final.jar:?]
	at io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:472) [netty-common-4.1.52.Final.jar:?]
	at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:500) [netty-transport-4.1.52.Final.jar:?]
	at io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:989) [netty-common-4.1.52.Final.jar:?]
	at io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74) [netty-common-4.1.52.Final.jar:?]
	at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30) [netty-common-4.1.52.Final.jar:?]
	at java.lang.Thread.run(Thread.java:834) [?:?]
Caused by: java.util.NoSuchElementException: reactor.netty.resources.PooledConnectionProvider$PooledConnectionAllocator$PooledConnectionInitializer
	at io.netty.channel.DefaultChannelPipeline.getContextOrDie(DefaultChannelPipeline.java:1082) ~[netty-transport-4.1.52.Final.jar:?]
	at io.netty.channel.DefaultChannelPipeline.remove(DefaultChannelPipeline.java:417) ~[netty-transport-4.1.52.Final.jar:?]
	at reactor.netty.resources.PooledConnectionProvider$PooledConnectionAllocator$PooledConnectionInitializer.handlerAdded(PooledConnectionProvider.java:284) ~[reactor-netty-0.9.12.RELEASE.jar:?]
	at io.netty.channel.AbstractChannelHandlerContext.callHandlerAdded(AbstractChannelHandlerContext.java:938) [netty-transport-4.1.52.Final.jar:?]
	at io.netty.channel.DefaultChannelPipeline.callHandlerAdded0(DefaultChannelPipeline.java:609) [netty-transport-4.1.52.Final.jar:?]
	... 14 more

@moderakh @FabianMeiswinkel - we will need to debug this issue as this will block us / everyone moving to the latest netty version.

We can let others move by updating external_dependencies.txt file and keeping netty dependency for cosmos on current versions, but it will be an issue for us soon once we want to upgrade.

kushagraThapar
kushagraThapar previously requested changes Sep 30, 2020
View reviewed changes
Copy link
Member

@kushagraThapar kushagraThapar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not merge this as it will break azure-cosmos SDK.

moderakh
moderakh previously requested changes Sep 30, 2020
View reviewed changes
Copy link
Contributor

@moderakh moderakh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should not get merged till cosmos db issue on newer version of netty is fixed.
Please don't merge this.

@kushagraThapar kushagraThapar mentioned this pull request Oct 20, 2020
Closed
@kushagraThapar
Copy link
Member

@chenrujun - It was a netty dependency issue in azure-cosmos Java SDK. I have fixed it through this PR - #16602

Once my PR is merged, you can rebase on the latest master and re-run the cosmos CI to check everything looks good.

@kushagraThapar kushagraThapar mentioned this pull request Oct 20, 2020
Merged
@kushagraThapar
Copy link
Member

@chenrujun - We have solved this dependency conflict issue here - #16604
Please rebase your PR with master and run the tests again to verify if the issue is resolved now.

@chenrujun chenrujun force-pushed the issue-15666-update-spring-boot-version-to-2.3.4.RELEASE branch from 4889048 to 2e76804 Compare October 22, 2020 02:05
@chenrujun
Copy link
Author

/azp run java - spring - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

yiliuTo
yiliuTo approved these changes Oct 22, 2020
View reviewed changes
Copy link
Member

@yiliuTo yiliuTo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chenrujun
Copy link
Author

/check-enforcer override

@chenrujun chenrujun dismissed stale reviews from moderakh and kushagraThapar October 22, 2020 08:22

cosmos db issue on newer version of netty is fixed

@chenrujun chenrujun merged commit ec9b001 into Azure:master Oct 22, 2020
@chenrujun chenrujun deleted the issue-15666-update-spring-boot-version-to-2.3.4.RELEASE branch October 22, 2020 08:24
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-java that referenced this pull request Aug 23, 2021
CodeGen from PR 15671 in Azure/azure-rest-api-specs
a3b332d 
update-typescript.md-for-resources (Azure#15671)

* update-typescript.md-for-resources

* update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshfree joshfree joshfree approved these changes

@yiliuTo yiliuTo yiliuTo approved these changes

@gapra-msft gapra-msft gapra-msft approved these changes

@alzimmermsft alzimmermsft alzimmermsft approved these changes

@moderakh moderakh moderakh left review comments

@kushagraThapar kushagraThapar kushagraThapar left review comments

@amishra-dev amishra-dev Awaiting requested review from amishra-dev

@anuchandy anuchandy Awaiting requested review from anuchandy

@bsiegel bsiegel Awaiting requested review from bsiegel

@ChenTanyi ChenTanyi Awaiting requested review from ChenTanyi

@conniey conniey Awaiting requested review from conniey

@danieljurek danieljurek Awaiting requested review from danieljurek

@David-Noble-at-work David-Noble-at-work Awaiting requested review from David-Noble-at-work

@g2vinay g2vinay Awaiting requested review from g2vinay

@hemanttanwar hemanttanwar Awaiting requested review from hemanttanwar

@jaschrep-msft jaschrep-msft Awaiting requested review from jaschrep-msft

@jialindai jialindai Awaiting requested review from jialindai

@jianghaolu jianghaolu Awaiting requested review from jianghaolu

@JianpingChen JianpingChen Awaiting requested review from JianpingChen

@JimSuplizio JimSuplizio Awaiting requested review from JimSuplizio

@JonathanGiles JonathanGiles Awaiting requested review from JonathanGiles

@kasobol-msft kasobol-msft Awaiting requested review from kasobol-msft

@kirankumarkolli kirankumarkolli Awaiting requested review from kirankumarkolli

@mbhaskar mbhaskar Awaiting requested review from mbhaskar

@milismsft milismsft Awaiting requested review from milismsft

@mitchdenny mitchdenny Awaiting requested review from mitchdenny

@mssfang mssfang Awaiting requested review from mssfang

@RezaJooyandeh RezaJooyandeh Awaiting requested review from RezaJooyandeh

@rickle-msft rickle-msft Awaiting requested review from rickle-msft

@samvaity samvaity Awaiting requested review from samvaity

@saragluna saragluna Awaiting requested review from saragluna

@schaabs schaabs Awaiting requested review from schaabs

@simplynaveen20 simplynaveen20 Awaiting requested review from simplynaveen20

@srnagar srnagar Awaiting requested review from srnagar

@vcolin7 vcolin7 Awaiting requested review from vcolin7

@weidongxu-microsoft weidongxu-microsoft Awaiting requested review from weidongxu-microsoft

@xseeseesee xseeseesee Awaiting requested review from xseeseesee

@xinlian12 xinlian12 Awaiting requested review from xinlian12

@YijunXieMS YijunXieMS Awaiting requested review from YijunXieMS

@yungezz yungezz Awaiting requested review from yungezz

@yvgopal yvgopal Awaiting requested review from yvgopal

@zhoufenqin zhoufenqin Awaiting requested review from zhoufenqin

@ankitarorabit ankitarorabit Awaiting requested review from ankitarorabit

@arerlend arerlend Awaiting requested review from arerlend

@backwind1233 backwind1233 Awaiting requested review from backwind1233

@mrm9084 mrm9084 Awaiting requested review from mrm9084

@sjkwak sjkwak Awaiting requested review from sjkwak

Assignees

@chenrujun chenrujun

Labels
App Configuration Azure.ApplicationModel.Configuration Azure.Core azure-core Azure.Identity azure-spring All azure-spring related issues Cosmos Event Hubs KeyVault Search Service Bus Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update spring-boot's version to 2.3.4.RELEASE.
8 participants
@chenrujun @kushagraThapar @joshfree @moderakh @alzimmermsft @gapra-msft @yiliuTo @rujche